Skip to content

Use cpu runner to build docs #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 14, 2025
Merged

Use cpu runner to build docs #434

merged 15 commits into from
Feb 14, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Feb 4, 2025

No description provided.

Copy link
Contributor

copy-pr-bot bot commented Feb 4, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Feb 4, 2025

/ok to test

@leofang
Copy link
Member Author

leofang commented Feb 4, 2025

/ok to test

This comment has been minimized.

@leofang
Copy link
Member Author

leofang commented Feb 4, 2025

@ksimpson-work looks like #398 is not the right fix. We still hit a lot of warnings when building cuda-core docs, starting here: https://github.com/NVIDIA/cuda-python/actions/runs/13137243830/job/36656488864?pr=434#step:18:469, and the system module doc is completely gone: https://nvidia.github.io/cuda-python/pr-preview/pr-434/cuda-core/latest/api.html#module-cuda.core.experimental.utils. Could you take a look?

@leofang leofang marked this pull request as draft February 4, 2025 15:03
Copy link
Contributor

copy-pr-bot bot commented Feb 4, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor

I will take a look. I recall the doc preview for #398 producing the appropriate system module documentation but it is gone now that we’ve merged. I will attempt to solve the problem with #398 and switch the cpu runner in a single review to address this issue

Copy link
Contributor

copy-pr-bot bot commented Feb 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor

/ok to test

@ksimpson-work
Copy link
Contributor

/ok to test

@leofang
Copy link
Member Author

leofang commented Feb 7, 2025

Warnings: https://github.com/NVIDIA/cuda-python/actions/runs/13169442707/job/36757434051#step:18:4911. I'll take a look next week. No need to sweat on this.

@ksimpson-work
Copy link
Contributor

@leofang I've been iterating on it

@ksimpson-work
Copy link
Contributor

/ok to test

@leofang
Copy link
Member Author

leofang commented Feb 12, 2025

/pre-commit.ci autofix

@leofang
Copy link
Member Author

leofang commented Feb 12, 2025

pre-commit.ci autofix

@leofang
Copy link
Member Author

leofang commented Feb 12, 2025

/ok to test

@leofang leofang marked this pull request as ready for review February 12, 2025 05:13
@leofang
Copy link
Member Author

leofang commented Feb 12, 2025

@ksimpson-work unfortunately we don't have any handle to where the API headers are generated, but at least I fixed pop() so that the correct name is shown (and as a side effect the weird grey box in the background is gone):
截圖 2025-02-12 上午12 14 46
I think you inserted the right lines (with the right name) but popped all lines so the fix was erased 😛

@leofang
Copy link
Member Author

leofang commented Feb 12, 2025

Would you mind give autoproperty a try? Currently we are using autodata.

@ksimpson-work
Copy link
Contributor

/ok to test

@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! CI/CD CI/CD infrastructure P1 Medium priority - Should do and removed P0 High priority - Must do! labels Feb 14, 2025
@leofang leofang added this to the cuda.core beta 3 milestone Feb 14, 2025
Co-authored-by: Leo Fang <leof@nvidia.com>
@ksimpson-work
Copy link
Contributor

/ok to test

@leofang
Copy link
Member Author

leofang commented Feb 14, 2025

I reverted the change. Let's merge! Thanks Keenan.

@leofang leofang merged commit db38fcd into NVIDIA:main Feb 14, 2025
1 check passed
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.
@leofang leofang deleted the cpu-doc branch February 14, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD infrastructure documentation Improvements or additions to documentation P1 Medium priority - Should do
2 participants