Skip to content

Ensure deprecation warnings from cuda.bindings are swallowed #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 16, 2025
Merged

Ensure deprecation warnings from cuda.bindings are swallowed #404

merged 11 commits into from
Jan 16, 2025

Conversation

ksimpson-work
Copy link
Contributor

close #282
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jan 16, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@ksimpson-work
Copy link
Contributor Author

/ok to test
leofang
leofang requested changes Jan 16, 2025
View reviewed changes
@ksimpson-work ksimpson-work self-assigned this Jan 16, 2025
@ksimpson-work ksimpson-work added P1 Medium priority - Should do cuda.core Everything related to the cuda.core module labels Jan 16, 2025
@ksimpson-work ksimpson-work added this to the cuda.core beta 3 milestone Jan 16, 2025
@ksimpson-work
Copy link
Contributor Author

/ok to test
@ksimpson-work ksimpson-work marked this pull request as ready for review January 16, 2025 17:02
@ksimpson-work
Copy link
Contributor Author

okay it's ready now :)
@ksimpson-work ksimpson-work requested a review from leofang January 16, 2025 18:12
@ksimpson-work
Copy link
Contributor Author

/ok to test
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang added the enhancement Any code-related improvements label Jan 16, 2025
leofang
leofang approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Keenan! I eyeballed a few test pipelines and no warning from the old layout is raised now.
@leofang leofang merged commit f0c304f into NVIDIA:main Jan 16, 2025
70 checks passed
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.
@leofang leofang mentioned this pull request Mar 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P1 Medium priority - Should do
2 participants
@ksimpson-work @leofang