Add back CuPy as an optional test dependency + Fix an example bug #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
/ok to test |
|
/ok to test |
leofang
commented
Dec 30, 2024
|
/ok to test |
ksimpson-work
approved these changes
Dec 30, 2024
Thanks, Keenan! Adding CuPy back is the main purpose of this PR. Everything else (updating/fixing the examples, adding test requirements, etc) are all done to serve this purpose, so as to make the CI green. I updated the PR description and title. |
rwgk
reviewed
Dec 31, 2024
| @@ -300,9 +300,9 @@ jobs: | |||
| - name: Run cuda.core tests | |||
| shell: bash --noprofile --norc -xeuo pipefail {0} | |||
| run: | | |||
| if [[ $SKIP_CUDA_BINDINGS_TEST == 1 ]]; then | |||
| if [[ ${{ matrix.python-version }} == "3.13" ]]; then | |||
There was a problem hiding this comment.
Just curious, what was the motivation for switching the order of ifs around here?
There was a problem hiding this comment.
Because I wrote this check and I got myself confused about what it meant. In a few weeks this part will be nuked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt of adding CuPy as an optional test dependency (4494a27). Previously we could not do it because
cupy.random.random()APIs (used in code samples) require cuRAND to exist and I did not want to inflate the cached CTK sizes. This PR switches to use the new random number generator, which does not require cuRAND (host library). It also has an additional benefit that we teach users to not use the legacy random APIs.An example bug on CUDA 11 is exposed as a result of this PR, which is also fixed (#334 (comment)).