Skip to content

switch the launch argument order #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 3, 2025
Merged

switch the launch argument order #316

merged 17 commits into from
Mar 3, 2025

Conversation

ksimpson-work
Copy link
Contributor

@ksimpson-work ksimpson-work commented Dec 19, 2024 •
edited
Loading

close #306

flip the launch args
@ksimpson-work ksimpson-work added P0 High priority - Must do! cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Dec 19, 2024
@ksimpson-work ksimpson-work self-assigned this Dec 19, 2024
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 19, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@leofang leofang added this to the cuda.core beta 3 milestone Dec 20, 2024
@leofang
Copy link
Member

leofang commented Dec 29, 2024

/ok to test
@ksimpson-work
Copy link
Contributor Author

/ok to test
@ksimpson-work ksimpson-work marked this pull request as ready for review January 1, 2025 22:01
@ksimpson-work ksimpson-work requested a review from leofang January 1, 2025 22:01
@leofang
Copy link
Member

leofang commented Jan 2, 2025

Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec.
@ksimpson-work
Copy link
Contributor Author

/ok to test
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@leofang leofang marked this pull request as draft January 17, 2025 03:52
@leofang
Copy link
Member

leofang commented Jan 17, 2025

Let's hold off merging for now. We need to wait for Bryce's update on the kernel spec.

@brycelelbach
@leofang

This comment was marked as resolved.

Sign in to view
@leofang leofang added triage Needs the team's attention and removed P0 High priority - Must do! labels Feb 20, 2025
@leofang leofang removed this from the cuda.core beta 3 milestone Feb 20, 2025
@leofang leofang mentioned this pull request Feb 20, 2025
Closed
@leofang leofang added this to the cuda.core beta 3 milestone Feb 26, 2025
@leofang leofang added P0 High priority - Must do! and removed triage Needs the team's attention labels Feb 27, 2025
@leofang
Copy link
Member

leofang commented Feb 27, 2025

Update: Discussed with Bryce and Keith offline, we want to get this PR included in beta 3.
@leofang
Copy link
Member

leofang commented Feb 27, 2025

/ok to test
leofang
leofang reviewed Feb 27, 2025
View reviewed changes
leofang
leofang requested changes Mar 1, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining code examples also need update.
@leofang
Copy link
Member

leofang commented Mar 1, 2025

/ok to test
@leofang
Copy link
Member

leofang commented Mar 2, 2025

TODO: Finalize the discussion on if we also want to pull out stream from config: launch(stream, config, kernel, *args).
@leofang leofang requested a review from vzhurba01 March 3, 2025 03:51
@vzhurba01
Copy link
Collaborator

/ok to test
@vzhurba01 vzhurba01 marked this pull request as ready for review March 3, 2025 21:00
leofang
leofang requested changes Mar 3, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thanks Vlad! Let's get the test part covered.
@vzhurba01
Copy link
Collaborator

/ok to test
@leofang leofang enabled auto-merge March 3, 2025 22:13
@leofang leofang merged commit 9b11611 into NVIDIA:main Mar 3, 2025
73 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module P0 High priority - Must do!
3 participants
@ksimpson-work @leofang @vzhurba01