Skip to content

fix: gemma-2 tokenizer #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
akoumpa wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: gemma-2 tokenizer #993

akoumpa wants to merge 4 commits into from

Conversation

@akoumpa
Copy link
Contributor

@akoumpa akoumpa commented Dec 19, 2025 •
edited
Loading

What does this PR do ?

Changes:

  • Fix gemma-2 (drop system message)
  • make NeMoAutoTokenizer a subclass of AutoTokenizer
  • add test

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)
@akoumpa
Fix gemma-2 (drop system message); make NeMoAutoTokenizer a subclass …
bf65305 
…of AutoTokenizer; add test

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@akoumpa akoumpa changed the title fix: gemma-2 tokenizer (drop system message); make NeMoAutoTokenizer a subclass … Dec 19, 2025
@akoumpa
fix
7c2319f 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test 7c2319f
@akoumpa
fix
8796b47 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test 8796b47
@akoumpa
lint
ebd8056 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa
Copy link
Contributor Author

akoumpa commented Dec 19, 2025

/ok to test ebd8056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@akoumpa