Skip to content

fix: add default arg for push_to_hub #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephantul merged 1 commit into from
May 14, 2025
Merged

fix: add default arg for push_to_hub #240

stephantul merged 1 commit into from
May 14, 2025

Conversation

@stephantul
Copy link
Contributor

@stephantul stephantul commented May 14, 2025

The push_to_hub subfolder argument was mistyped as str and didn't take None as a default argument. This adds str | None as the type, and None as a default.
@stephantul stephantul requested a review from Pringled May 14, 2025 06:18
@codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/inference/model.py 92.38% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@stephantul stephantul merged commit 562c14d into main May 14, 2025
6 checks passed
@stephantul stephantul deleted the fix-default-arg-pipeline branch May 14, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@stephantul @Pringled