Skip to content

fix: precision during training #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephantul merged 1 commit into from
Apr 28, 2025
Merged

fix: precision during training #228

stephantul merged 1 commit into from
Apr 28, 2025

Conversation

@stephantul
Copy link
Contributor

@stephantul stephantul commented Apr 28, 2025 •
edited
Loading

Using a half precision or int8 model would break training.

Half precision only breaks on CPU, but int8 always breaks, because int8 embeddings are not supported in pytorch.
@stephantul stephantul requested a review from Pringled April 28, 2025 10:39
@codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
model2vec/train/base.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@stephantul stephantul merged commit 7905629 into main Apr 28, 2025
6 checks passed
@stephantul stephantul deleted the fix-precision-training branch April 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@stephantul @Pringled