Skip to content

Conversation

@stephantul
Copy link
Contributor

Small typing issues: we actually accept non-list sequences in almost all our functions, but type them as list. This should be Sequence[str]. Since str is also Sequence[str], we can just use a single type in most places, and no longer have to use a union.

Inference pipeline saving was broken (my bad)

@stephantul stephantul requested a review from Pringled April 25, 2025 06:54
@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
model2vec/inference/model.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
model2vec/model.py 94.15% <100.00%> (+0.15%) ⬆️
model2vec/inference/model.py 92.38% <66.66%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@stephantul stephantul merged commit 77f16df into main Apr 25, 2025
5 of 6 checks passed
@stephantul stephantul deleted the fix-typing branch April 25, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants