feat: add quantization #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Pringled
approved these changes
Apr 21, 2025
| return embeddings.astype(np.float64) | ||
| elif quantize_to == DType.Int8: | ||
| # Normalize to [-127, 127] range for int8 | ||
| scale = np.max(np.abs(embeddings)) / 127.0 |
Member
There was a problem hiding this comment.
Can this ever be 0 (zero division issues?)
Contributor
Author
There was a problem hiding this comment.
Only if all embeddings are 0
model2vec/quantization.py
Outdated
| elif quantize_to == DType.Float64: | ||
| return embeddings.astype(np.float64) | ||
| elif quantize_to == DType.Int8: | ||
| # Normalize to [-127, 127] range for int8 |
Member
There was a problem hiding this comment.
Should this not be [-128, 127] (the range of an 8-bit signed integer)? Not sure if it's relevant for the code though since it doesn't change the division.
Contributor
Author
There was a problem hiding this comment.
I think the symmetry is more important than making sure the 1 extra value is used. I updated the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds quantization. Quantization can be applied during distillation, or during loading. Both are equivalent, except that distill-time quantization leads to smaller embedding sizes.