Skip to content

Update unmanaged-disks-deprecation.md #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update unmanaged-disks-deprecation.md #207

wants to merge 3 commits into from

Conversation

adatcher
Copy link

No description provided.

@prmerger-automator PRMerger Automator
Copy link
Contributor

@adatcher : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.
@prmerger-automator prmerger-automator bot requested a review from ju-shim April 21, 2025 19:44
@adatcher
Copy link
Author

PM sign off
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit bf0bf12:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/unmanaged-disks-deprecation.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:
@v-dirichards
Copy link
Contributor

Hi @adatcher - it looks like you have access to the private repo, and if so - you should use that for content updates. I'll leave this open in case @roygara wants to review it, but in the future you should submit changes to the private repo: azure-compute-docs-pr.

@roygara

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team
@prmerger-automator prmerger-automator bot added the aq-pr-triaged C+L Pull Request Review Team label label Apr 21, 2025
@adatcher
Copy link
Author

#sign-off
@prmerger-automator PRMerger Automator
Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @roygara
@v-dirichards
Copy link
Contributor

Hi @adatcher - Thanks for your review. In the public repo, pull requests should be signed off by the author, another member of the content team, or a PM.

@roygara Could you take a look? Thanks!
roygara
roygara reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@roygara roygara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, after this is integrated, I'll go ahead and signoff.

Thanks! :)
v-dirichards and others added 2 commits April 24, 2025 10:26
@v-dirichards @roygara
committing per author's approval
84fd41f 
Co-authored-by: rogara <31490067+roygara@users.noreply.github.com>
@v-dirichards @roygara
commiting author's edits
78bbc81 
Co-authored-by: rogara <31490067+roygara@users.noreply.github.com>
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 78bbc81:

✅ Validation status: passed

File Status Preview URL Details
articles/virtual-machines/unmanaged-disks-deprecation.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:
@v-dirichards
Copy link
Contributor

@roygara Ready for your review and sign off. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aq-pr-triaged C+L Pull Request Review Team label azure-disk-storage/svc Change sent to author do-not-merge
3 participants
@adatcher @v-dirichards @roygara