Skip to content

Conversation

@SaeedHurzuk
Copy link

  • Boosted the mirror's ego with better compliments.
  • Upgrade compliment variety and tone
- Boosted the mirror's ego with better compliments.
- Upgrade compliment variety and tone
@sdetweil
Copy link
Collaborator

Why? You can put yours in config.js to show anything you want

and you can put them in a file instead of config.js and update them live. No need to update the default sayings

@sdetweil
Copy link
Collaborator

MagicMirror design is everything in config.js overrides what is in the modules.

@SaeedHurzuk
Copy link
Author

Why? You can put yours in config.js to show anything you want

and you can put them in a file instead of config.js and update them live. No need to update the default sayings

Give's it fresh new compliments, i noticed it has not been updated in ages.

@rejas
Copy link
Collaborator

rejas commented Jan 30, 2026

Give's it fresh new compliments, i noticed it has not been updated in ages.

I agree with Sam, this doesnt need it updating. Thanks for your interest in MM though!

@KristjanESPERANTO
Copy link
Collaborator

I'm wondering: could there be value in refreshing the defaults? Not everyone customizes immediately, and some new users will see these defaults for weeks or months. Since they haven't changed in a long time, a refresh could improve that first impression - though I admit I can't judge the specific wording as a non-native speaker.

I don't want to drag this out, but I wanted to share that perspective. I'm also perfectly fine with not pursuing this further. Sam's argument is totally valid.

@sdetweil
Copy link
Collaborator

I think the current values would motivate users to learn how to change them. Which is one of our goals

@KristjanESPERANTO
Copy link
Collaborator

I think the current values would motivate users to learn how to change them. Which is one of our goals

Oh, that's a very good point 👍

Okay, then I hereby close this PR. @SaeedHurzuk, thank you for your efforts! Don't let this discourage you from suggest other changes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants