Repository navigation
Conversation
…s via existing GitHub authority
…cident work-item flow
…fail-closed classification
…l diagnostics store
… non-live release evidence
…ted release observations
…for release evidence
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact gap
LEGEND's sole release lifecycle emits terminal, authenticated GitHub release evidence, but
LegendEngineeringOrchestrator.ProcessIncidentsAsynconly reads runtime incidents. Release failures therefore never reach the existing durable engineering work-item/notification system. Raw logs cannot be treated as executable instructions, and a failed candidate SHA is NOT a verified live runtime SHA.Surgical implementation
workflow_dispatchrelease failures. Require exact protected workflow path, approved branch, repository, immutable title/source/authority identity, merged PR source, protected merge ancestry, and exactly one failed terminal release job. Classify the first failed stage from fixed known step labels; NEVER ingest logs or provider error text.LegendEngineeringOrchestrator.ProcessIncidentsAsyncintake, hand authenticated run/candidate/authority/stage values to Infrastructure.Diagnostics.RuntimeDiagnosticStore, the canonical and soleRuntimeDiagnosticIncidentswriter. It constructs sanitized evidence, validates exact fixed stages, inserts once with the existing unique fingerprint, and reconciles a concurrent identical insertion without inflating terminal historical observations. The existingLegendEngineeringStateStore.AttachIncidentAsyncconsumes the incident on the same pass. Existing hosted service already invokes this routine; no new scheduler or workflow.ReleaseVerified=false,SourceFilePath=null, and keep the classified item Tier C until source/production capabilities receive separate governance and live proof. The candidate SHA is provenance only, not the live SHA. A release failure alone cannot authorize CodeX GitHub writes, Founder approvals, a merge or a deployment.Locked safeguards
Zero edits to
scripts/validation-resume.py, reusable validation parents/children, packaging/evidence IDs, deployment, database schema/migrations, cloud settings, queue admission, release authorizers, security classifications, or existing remediation write authority. Do not broaden SAFE_SOURCE/IntegrityProtected permissions. PRs #525-528 remain untouched and follow their own canonical CI. This PR is a safe release-failure evidence handoff, not a claim that release-control source can auto-repair or that any release deployed successfully.Proof / no promotion before proof
Protected exact-head architecture/security and all required dependency gates; read-only synthetic GitHub evidence + negative tests, concurrency dedupe, configured service readiness, and distinct live-provenance checks. Keep draft and unmerged until all of these are green. This handoff must fail closed if source lineage or evidence inventory is incomplete.