-
Notifications
You must be signed in to change notification settings - Fork 14
Adding POX Docker Image #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skazza94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RicGobs,
thanks for the PR. I have some changes to ask.
Thank you!
Mariano.
| ARG DEBIAN_FRONTEND="noninteractive" | ||
| RUN apt clean all | ||
| RUN apt update | ||
| RUN apt install -y zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libsqlite3-dev libreadline-dev libffi-dev curl libbz2-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After compiling Python3.9, I think you can remove these libraries.
|
|
||
| # Clone and set permissions for pox | ||
| RUN git clone https://github.com/noxrepo/pox.git && \ | ||
| chmod +x /pox/pox.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the following snippet at the end of the Dockerfile to clean up caches/other:
RUN apt clean && \
rm -rf /tmp/* /var/lib/apt/lists/* /var/tmp/*
|
Hi @Skazza94, I have done the following:
Tell me if other is needed. Bye |
Skazza94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RicGobs,
thanks for the changes. The PR looks good! 😄
Hi,
Here it is a Docker POX image, to allow using POX without importing POX as a Git submodule. The new image is based on the kathara/base image.
The Docker image is needed for the sdn-openflow labs (located in the main labs directory).