Skip to content

Conversation

@RicGobs
Copy link
Contributor

@RicGobs RicGobs commented Feb 13, 2024

Hi,

Here it is a Docker POX image, to allow using POX without importing POX as a Git submodule. The new image is based on the kathara/base image.

The Docker image is needed for the sdn-openflow labs (located in the main labs directory).

@tcaiazzi tcaiazzi requested a review from Skazza94 February 20, 2024 11:06
Copy link
Member

@Skazza94 Skazza94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RicGobs,
thanks for the PR. I have some changes to ask.

Thank you!
Mariano.

ARG DEBIAN_FRONTEND="noninteractive"
RUN apt clean all
RUN apt update
RUN apt install -y zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libsqlite3-dev libreadline-dev libffi-dev curl libbz2-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After compiling Python3.9, I think you can remove these libraries.


# Clone and set permissions for pox
RUN git clone https://github.com/noxrepo/pox.git && \
chmod +x /pox/pox.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following snippet at the end of the Dockerfile to clean up caches/other:

RUN apt clean && \
    rm -rf /tmp/* /var/lib/apt/lists/* /var/tmp/*
@RicGobs
Copy link
Contributor Author

RicGobs commented Feb 28, 2024

Hi @Skazza94,

I have done the following:

  • added the snippet code at the end (for the cache)
  • removed zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libsqlite3-dev libreadline-dev libffi-dev curl libbz2-dev (after their use)
  • done a test (it works on my labs)

Tell me if other is needed. Bye
Riccardo

Copy link
Member

@Skazza94 Skazza94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RicGobs,
thanks for the changes. The PR looks good! 😄

@Skazza94 Skazza94 merged commit f293eb6 into KatharaFramework:main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants