Fix invalid escape sequence in regex #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the regex in pandoc_download.py to correctly escape the period character. This change resolves the SyntaxWarning triggered by an invalid escape sequence and ensures compatibility with future Python versions.
Owner
|
@syusuke9999 it seems that this change breaks the download pandoc functionality in the CI pipeline. Could you take a look at this |
Adjusted the regex to fix URL matching issues identified during CI tests, ensuring effective Pandoc downloads.
Contributor
Author
|
Thanks for the feedback, @JessicaTegner. I've adjusted the regex to fix the CI download issues and verified that it now works as intended. Please review the changes at your convenience. |
Owner
|
@syusuke9999 seems good to me. Thank you so much for the pr :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the regex in pandoc_download.py to correctly escape the period character. This change resolves the SyntaxWarning triggered by an invalid escape sequence and ensures compatibility with future Python versions.