Remove logic for python2 #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __future__ statements we used were: - absolute_import - Mandatory in 3.0 - with_statement - Mandatory in 2.6 - print_function - Mandatory in 3.0 As we only support python >= 3.6 - this can be removed now
We were handling compat for py2 and py3 (mainly for urllib) Now this is not required as we expect python >= 3.6
In py3 they are both str() So, remove logic for the types as we support py3.6+ only
path2url was only used in 1 placce (in tests) so remove the function And move url2path into the `__init__` file where it is used twice
This function was only used in 1 place and always with encoding="utf-8" being hardcoded So, remove the function and just use the logic required because in py3.6+ it is a 1 liner: s.encode(...)
This function is a simple function now that we support only py3.6+ So, remove the original function and use the logic a required
funkyfuture
reviewed
Sep 7, 2023
| @@ -1,5 +1,4 @@ | |||
| # -*- coding: utf-8 -*- | |||
funkyfuture
reviewed
Sep 7, 2023
There was a problem hiding this comment.
could the remaining contents of this module moved into another one?
JessicaTegner
force-pushed
the
master
branch
2 times, most recently
from
06c6f0a to
35035f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library currently cannot be installed on py2 because of
setup_requires=">=3.6"So, remove code for python 2