Skip to content

Conversation

@ickc
Copy link
Contributor

@ickc ickc commented Jan 16, 2017

This is after #126, and any potential changes you want to make before v1.4.

@jankatins
Copy link
Contributor

LGTM, will merge after the other PR #128

@ickc
Copy link
Contributor Author

ickc commented Feb 12, 2017

Also this one?

@jankatins
Copy link
Contributor

@ickc Sorry for the delay, I need to setup my dev machine and then will merge this and tag the release. The other PRs were simply merged in the github web UI...

@ickc
Copy link
Contributor Author

ickc commented Feb 14, 2017

You can also git tag it in releases. If you have setup Travis to deploy to PyPI, that would works for PyPI deployment too.

Anyway, take your time.

@ickc
Copy link
Contributor Author

ickc commented Apr 1, 2017

@JanSchulz, merge now?

@jankatins
Copy link
Contributor

Close and reopen to check CI builds

@jankatins jankatins closed this Apr 14, 2017
@jankatins jankatins reopened this Apr 14, 2017
@jankatins jankatins merged commit f4eabac into JessicaTegner:master Apr 22, 2017
@jankatins
Copy link
Contributor

@ickc Sorry that it took so long :-(

@ickc
Copy link
Contributor Author

ickc commented Apr 22, 2017

No problem! After all, these are our volunteer jobs and we have the other one that consumes most of our time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants