-
-
Notifications
You must be signed in to change notification settings - Fork 122
Ensure $HOME is set before calling pandoc --version
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
since pandoc tries to lookup $HOME
|
Looks good to me. @JanSchulz Any thoughts? Want to merge and publish? |
|
LGTM... The problem I have right now is that I don't have my package builder running. I can cut a "normal" release without a problem, but not the wheels with embedded pandoc. So:
|
|
Yeah, that's fine. I guess the embedded release can wait. Would it be possible to push that somewhere so it's easier to handle? |
|
I had them build with the conda packages for my pwn channel, but doesn't work anymore :-( I want to have a similar setup: three CI services which build the wheels and upload them. Still waiting for some twine changes and then I have to sit down and write the CI scripts. But the latter seems to take a bit of time... A bit more probably, as debugging is hard with CI scripts :-/ |
|
Btw @tkob Does converting work? Or does that also need the same workaround? |
|
I believe |
|
@tkob Thanks! Looks like this was missed upstream? Maybe file a bug there? |
|
@bebraw I've cut a new release (1.2.0) and uploaded the sdist and updated the conda packages. |
|
Nice. 👍 |
This PR fixes the problem described in #103 .
In #103, I suggested using
--data-diroption, but it is not usable since pandoc ignores--data-diroption if--versionis specified.This PR takes another aproach; creates an environment which is local to
pandoc --versionand supply $HOME if it is not set.