Skip to content

Conversation

@tkob
Copy link
Contributor

@tkob tkob commented Jul 11, 2016

This PR fixes the problem described in #103 .

In #103, I suggested using --data-dir option, but it is not usable since pandoc ignores --data-dir option if --version is specified.

This PR takes another aproach; creates an environment which is local to pandoc --version and supply $HOME if it is not set.

since pandoc tries to lookup $HOME
@bebraw
Copy link
Contributor

bebraw commented Jul 11, 2016

Looks good to me.

@JanSchulz Any thoughts? Want to merge and publish?

@jankatins
Copy link
Contributor

LGTM...

The problem I have right now is that I don't have my package builder running. I can cut a "normal" release without a problem, but not the wheels with embedded pandoc.

So:

  • normal source release is possible
  • conda packages (via conda-forge) are possible
  • wheels with pandoc included are not
@jankatins jankatins merged commit 6658b7d into JessicaTegner:master Jul 12, 2016
@bebraw
Copy link
Contributor

bebraw commented Jul 12, 2016

Yeah, that's fine. I guess the embedded release can wait. Would it be possible to push that somewhere so it's easier to handle?

@jankatins
Copy link
Contributor

I had them build with the conda packages for my pwn channel, but doesn't work anymore :-( I want to have a similar setup: three CI services which build the wheels and upload them. Still waiting for some twine changes and then I have to sit down and write the CI scripts. But the latter seems to take a bit of time... A bit more probably, as debugging is hard with CI scripts :-/

@jankatins
Copy link
Contributor

Btw @tkob Does converting work? Or does that also need the same workaround?

@tkob
Copy link
Contributor Author

tkob commented Jul 13, 2016

I believe convert() etc. now work since pandoc (i.e. no --version) does not fail when HOME is not set:

$ unset HOME
$ echo hello | pandoc
<p>hello</p>
$ pandoc --version
pandoc: HOME: getAppUserDataDirectory: does not exist (no environment variable)
@tkob tkob deleted the supply-home branch July 13, 2016 13:02
@jankatins
Copy link
Contributor

@tkob Thanks!

Looks like this was missed upstream? Maybe file a bug there?

@jankatins
Copy link
Contributor

@bebraw I've cut a new release (1.2.0) and uploaded the sdist and updated the conda packages.

@bebraw
Copy link
Contributor

bebraw commented Jul 13, 2016

Nice. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants