[Feature] Refine Sequence Parallel API #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t have shape (bs, seq_len, dim)
… post_process_for_sequence_parallel_attn, to the user
pppppM
approved these changes
Apr 15, 2024
llkn-2
pushed a commit
to llkn-2/xtuner
that referenced
this pull request
Jul 31, 2024
* refine split_for_sequence_parallel API, the tensor to be split may not have shape (bs, seq_len, dim) * Expose the two interfaces, pre_process_for_sequence_parallel_attn and post_process_for_sequence_parallel_attn, to the user * Assert pytorch version != 2.1 * Remove the PyTorch version restriction when using sequence parallel * refine all_to_all op * split sequence in sft but not data_collate_fn * add sequence communications * fix lint * move all_to_all to communications * make compute_sequence_parallel_loss method private * fix sp docs * rename * add explanation about why grad_scale is needed * refine * add docstring * rename communications to comm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimized the API design for increased generality.