Skip to content

[Fix] Fix Division-by-zero error when warmup steps set the same as total steps #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nil0x9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Fix] Fix Division-by-zero error when warmup steps set the same as total steps #1285

nil0x9 wants to merge 1 commit into from

Conversation

@nil0x9
Copy link
Contributor

@nil0x9 nil0x9 commented Nov 21, 2025

Currently if user set warmup steps to be the same as total steps (which is deemed valid) for cosine or linear LR scheduler, a division-by-zero error will be thrown. This PR fixes this case (along w/ some lint issues).
@nil0x9 nil0x9 force-pushed the linty/dev-fix-lr-scheduler-corner-case branch from 416c867 to 85ed80e Compare November 21, 2025 17:56
@nil0x9 nil0x9 force-pushed the linty/dev-fix-lr-scheduler-corner-case branch from 85ed80e to 0980ccb Compare November 22, 2025 19:32
@hhaAndroid hhaAndroid requested a review from jayhenry November 24, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@nil0x9