Bump Three.js to r147 #38
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Author
|
Switched to draft. Currently the latest Three.js release is r152. It doesn't really make sense to upgrade to older revision (r147). When we upgrade Three.js next time, we can upgrade to the latest one. We might reuse this PR or branch because the changes in this PR will be needed anyways. Also refer to Hubs-Foundation/hubs#5852 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Hubs-Foundation/hubs#5852
Current our A-Frame fork seems to block Three.js r147 install in Hubs. It seems to need to upgrade Three.js to r147 in A-Frame, too.