Skip to content

fix(frontend): CSR builds were missing env vars due to import.meta.env not being used #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daveearley merged 3 commits into from
Jul 23, 2025
Merged

fix(frontend): CSR builds were missing env vars due to import.meta.env not being used #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dad3c07
refactor(frontend): Replace string-based ConfigKeys with a strict uni…
carlosalaniz Jun 29, 2025
be08579
Add missing keys
carlosalaniz Jun 29, 2025
6577fcb
Update frontend/src/utilites/config.ts
carlosalaniz Jun 30, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions frontend/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,25 @@
*/
import {SupportedLocales} from "./locales.ts";

export type ConfigKeys = 'VITE_FRONTEND_URL'
| 'VITE_API_URL_CLIENT'
| 'VITE_STRIPE_PUBLISHABLE_KEY'
export type ConfigKeys =
| 'VITE_API_URL_SERVER'
| 'VITE_CHATWOOT_WEBSITE_TOKEN'
| 'VITE_CHATWOOT_BASE_URL'
| 'VITE_API_URL_CLIENT'
| 'VITE_FRONTEND_URL'
| 'VITE_APP_PRIMARY_COLOR'
| 'VITE_APP_SECONDARY_COLOR'
| 'VITE_APP_NAME'
| 'VITE_PLATFORM_SUPPORT_EMAIL'
| 'VITE_APP_FAVICON'
| 'VITE_APP_LOGO_DARK'
| 'VITE_APP_LOGO_LIGHT'
| 'VITE_CHATWOOT_BASE_URL'
| 'VITE_CHATWOOT_WEBSITE_TOKEN'
| 'VITE_HIDE_ABOUT_LINK'
| 'VITE_TOS_URL'
| 'VITE_PRIVACY_URL'
| string;
| 'VITE_PLATFORM_SUPPORT_EMAIL'
| 'VITE_STRIPE_PUBLISHABLE_KEY'
| 'VITE_I_HAVE_PURCHASED_A_LICENCE'
| 'VITE_DEFAULT_IMAGE_URL';

export type IdParam = string | undefined | number;

Expand Down
28 changes: 25 additions & 3 deletions frontend/src/utilites/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,34 @@ import { ConfigKeys } from "../types.ts";
import { isSsr } from "./helpers.ts";
import process from "process";

export const getConfig = ( key: ConfigKeys, fallback?: string ): string | undefined => {

export const clientBuildEnv: { [K in ConfigKeys]: string } = {
'VITE_APP_PRIMARY_COLOR': import.meta.env.VITE_APP_PRIMARY_COLOR,
'VITE_APP_SECONDARY_COLOR': import.meta.env.VITE_APP_SECONDARY_COLOR,
'VITE_APP_NAME': import.meta.env.VITE_APP_NAME,
'VITE_APP_FAVICON': import.meta.env.VITE_APP_FAVICON,
'VITE_APP_LOGO_DARK': import.meta.env.VITE_APP_LOGO_DARK,
'VITE_APP_LOGO_LIGHT': import.meta.env.VITE_APP_LOGO_LIGHT,
'VITE_CHATWOOT_BASE_URL': import.meta.env.VITE_CHATWOOT_BASE_URL,
'VITE_CHATWOOT_WEBSITE_TOKEN': import.meta.env.VITE_CHATWOOT_WEBSITE_TOKEN,
'VITE_HIDE_ABOUT_LINK': import.meta.env.VITE_HIDE_ABOUT_LINK,
'VITE_TOS_URL': import.meta.env.VITE_TOS_URL,
'VITE_PRIVACY_URL': import.meta.env.VITE_PRIVACY_URL,
'VITE_PLATFORM_SUPPORT_EMAIL': import.meta.env.VITE_PLATFORM_SUPPORT_EMAIL,
'VITE_STRIPE_PUBLISHABLE_KEY': import.meta.env.VITE_STRIPE_PUBLISHABLE_KEY,
'VITE_I_HAVE_PURCHASED_A_LICENCE': import.meta.env.VITE_I_HAVE_PURCHASED_A_LICENCE,
'VITE_FRONTEND_URL': import.meta.env.VITE_FRONTEND_URL,
'VITE_DEFAULT_IMAGE_URL': import.meta.env.VITE_DEFAULT_IMAGE_URL,
'VITE_API_URL_SERVER': import.meta.env.VITE_API_URL_SERVER,
'VITE_API_URL_CLIENT': import.meta.env.VITE_API_URL_CLIENT
}

export const getConfig = (key: ConfigKeys, fallback?: string): string | undefined => {
if (isSsr()) {
const serverEnv = typeof process !== "undefined" && process.env ? process.env : {};
return serverEnv[ key ] as string | undefined || fallback;
return serverEnv[key] as string | undefined || fallback;
}

const clientEnv = typeof window !== "undefined" && window.hievents ? window.hievents : {};
return clientEnv[key] || fallback;
return clientEnv[key] || clientBuildEnv[key] || fallback;
};