feat: support Z.ai coding platform (#34)#35
Conversation
warren618
left a comment
There was a problem hiding this comment.
Thanks for the contribution! A few things to address before merging:
-
Missing tests: PR #33 added unit tests for the MiniMax provider mapping — please add a similar
test_zai_providertest inagent/tests/test_llm.pyto cover theZAI_API_KEY/ZAI_BASE_URLmapping. -
README_ja.md trailing character: The last line adds a stray
>— please remove it. -
Don't modify News sections: News entries are maintained by the maintainer as a daily summary of all commits. Please revert the News changes in all READMEs.
-
Rebase needed: Once #33 is merged, please rebase onto the latest
mainsince both PRs touch.env.exampleandllm.py.
Fixed. Thank you for your reply! |
|
LGTM, merged! Thanks @jiakeboge for the quick turnaround on all the feedback — clean work 👍 @twlun1986 Z.ai is now supported on main. Grab the latest and run |
Summary
Why
Closes #34. Currently, users cannot easily configure the Z.ai coding platform, and using it via generic OpenAI settings often leads to base URL resolution errors.
Changes
Test Plan
Checklist