Skip to content

fix: make harmonic backend optional#250

Merged
warren618 merged 1 commit into
mainfrom
fix/optional-harmonic-dependency
Jun 16, 2026
Merged

fix: make harmonic backend optional#250
warren618 merged 1 commit into
mainfrom
fix/optional-harmonic-dependency

Conversation

@warren618

Copy link
Copy Markdown
Collaborator

Summary

Fix Windows/Python baseline installs by moving the optional pyharmonics harmonic-pattern backend out of the core dependency set and into a dedicated harmonic extra.

Root Cause

vibe-trading-ai depended on pyharmonics>=1.5.0 unconditionally. pyharmonics depends on ta, which can be unavailable in some Windows/Python resolver environments, so a non-core harmonic-pattern backend could block pip install vibe-trading-ai entirely.

Changes

  • Remove pyharmonics from core pyproject.toml dependencies and agent/requirements.txt.
  • Add pyharmonics>=1.5.0 as vibe-trading-ai[harmonic].
  • Update the harmonic skill install instructions to use the extra and document the bundled fallback detector.
  • Add a packaging regression test that keeps pyharmonics out of baseline installs while preserving the optional extra.

Fixes #249.

Validation

  • python -m pytest agent/tests/test_packaging_dependencies.py -q
  • python -m compileall -q agent/tests/test_packaging_dependencies.py
  • python -m pip install --dry-run --ignore-installed --no-deps .
  • git diff --check
@warren618 warren618 merged commit 75e480c into main Jun 16, 2026
1 check passed
@warren618 warren618 deleted the fix/optional-harmonic-dependency branch June 16, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant