Avoid unzipping .nupkg every time we need to read from .nuspec by saving .nuspec inside the package folder instead of .nupkg

[popara96]

Backwards compatibility is managed by checking for .nupkg files and if there are some, we unpack .nuspec file from them and delete them. Tests have also been changed accordingly.

[JoC0de]

Hi,
The failing tests are the one that try to install a nuget package from a lokal package source. Most probably the issue is in the setup because it needs the .nupkg file from a previous install to create a lokal package source.

[JoC0de]

We need to rebase, and there is one missing conversation

[popara96]

After this gets approved, I will push the squashed commit directly to master.

[JoC0de]

@popara96 why directly pushing to master. I don't like when PRs are skipped as they ensure e.g. that the CI works. I would just squash the commits -> rebase -> merge PR. So we keep the link to the PR / it will be listed correctly inside the Release Nodes.

[igor84]

Does that mean we force push the branch after rebase + squash? We were not sure if we force push was allowed.

[JoC0de]

Does that mean we force push the branch after rebase + squash? We were not sure if we force push was allowed.

Yes force-push on branches is allowed (not on main), you can do --force-with-leas so the complete history still exists. At leas I do it, but I always create branches on my fork. Without force-push it would be also possible but then you need to do a merge commit (I also prefer rebase over merging)