Move filter.py from xDEM to GeoUtils and integrate into raster class #699
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #690
I'm picking up @vschaffn's work on filter management from geoutils. I couldn't find any other way than to create a new PR. Valentin's history should be preserved.
I've tried to incorporate the other feedback, with more tests and better handling of NaNs without _nan_safe_filter.
Previous PR
Context
The current filter.py module in xDEM provides a collection of filters that are highly useful for digital elevation models (DEMs). However, these filtering utilities are not intrinsically tied to elevation data—they are generally applicable to any geospatial raster data. Given this, it makes more architectural sense for them to live in GeoUtils.
Changes
Tests
Documentation
Note
When this ticket is approved, a linked PR to remove filters in xDEM will be opened.