Named branch configuration #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@GitTools/developers would love a review on this, it's a decent change. Anything you can see which can be improved? |
| SetupConfigFileContent(text); | ||
| var error = Should.Throw<OldConfigurationException>(() => ConfigurationProvider.Provide(repoPath, fileSystem)); | ||
| error.Message.ShouldContainWithoutWhitespace(@"GitVersion configuration file contains old configuration, please fix the following errors: | ||
| GitVersion branch configs no longer are keyed by regexes, update: |
Contributor
Author
There was a problem hiding this comment.
I put a bit of effort into the error messages to give a good upgrade experience.
Member
|
What about https://github.com/GitTools/GitVersion/blob/master/BREAKING%20CHANGES.md? IMHO it would be nice to have this updated too with all the breaking changes like this and others introduced in 4.0 |
JakeGinnivan
force-pushed
the
namedBranchConfigs
branch
from
9090dbd to
4a1b591
Compare
Contributor
Author
|
@pascalberger nice idea, done. |
Member
|
@JakeGinnivan Excellent change! 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// @asbjornu @gep13
No implementation yet, but happy with the docs/test changes before I implement
Fixes #995