[GSK-2248] TestResult to dict #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSK-2248 Generate JSON output from the tests
This should be the last step of the short-term milestone. We should get feedback from Alex on this to finalise the format. |
Hartorn
requested changes
Dec 14, 2023
loreal_poc/dataloaders/base.py
Outdated
| def __init__(self, dataloader: DataIteratorBase) -> None: | ||
| def __init__(self, dataloader: DataIteratorBase, name: Optional[str] = None) -> None: | ||
| self._wrapped_dataloader = dataloader | ||
| self.name = name |
Member
There was a problem hiding this comment.
Not needed, any call to .name would be redirected to self._wrapped_dataloader.name, using __getattr__
Or you could add a func with @property.getter, to add some description like :
@property.getter
def name(self):
return f"Wrapper({self._wrapped_dataloader.name}")
loreal_poc/dataloaders/wrappers.py
Outdated
| crop_marks: bool = True, | ||
| ) -> None: | ||
| super().__init__(dataloader) | ||
| name = f"Cropped on {part.name}" |
Member
There was a problem hiding this comment.
Kind of same as for the base class, could be a method
@property.getter
def name(self):
return f"{self._wrapped_dataloader.name} cropped on {self._part}")
loreal_poc/dataloaders/wrappers.py
Outdated
| class CachedDataLoader(DataLoaderWrapper): | ||
| def __init__(self, dataloader: DataIteratorBase, cache_size: int = 20) -> None: | ||
| super().__init__(dataloader) | ||
| super().__init__(dataloader, name="Cached") |
| ) | ||
|
|
||
| def to_dict(self): | ||
| return { |
Contributor
Author
There was a problem hiding this comment.
For now I don't need all the attributes of TestResult to be included. But yeah, probably the remaining ones could be eliminated in the future if we don't need them, and to_dict can be therefore also eliminated in favour of asdict. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.