Skip to content

Conversation

@rabah-khalek
Copy link
Contributor

@rabah-khalek rabah-khalek commented Jul 22, 2024

Support for object detection models/datasets

@rabah-khalek rabah-khalek marked this pull request as draft July 25, 2024 12:29
@rabah-khalek rabah-khalek marked this pull request as ready for review August 5, 2024 08:49
@rabah-khalek rabah-khalek requested a review from Inokinoki August 5, 2024 08:49
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the files are reviewed in Benoit's branch, except the racoon model.
LGTM at the moment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the .DS_Store.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these images cherry-picked to have only one raccoon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

return self.detector(imgs)


class FasterRCNNBase(ModelBase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


from ..types import TypesBase

EthicalIssueMeta = IssueGroup(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also moved them somewhere in #49

Let's merge your PR first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@rabah-khalek rabah-khalek merged commit 453f277 into main Aug 7, 2024
@rabah-khalek rabah-khalek deleted the object-detection branch August 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants