[GSK-2244] Head Pose Criterion #22
Conversation
GSK-2244 Performance on different face orientations
We need to scope an AI model to estimate this like google's API Cloud Vision. |
Hartorn
left a comment
Hartorn
left a comment
There was a problem hiding this comment.
Only one question about super.init :)
loreal_poc/dataloaders/wrappers.py
Outdated
|
|
||
| super().__init__(dataloader) | ||
|
|
||
| self.pose_detection_model = SixDRepNet(gpu_id=-1) |
There was a problem hiding this comment.
Yeah -1 is cpu, I'll make this one a parameter, just in case people want to run it on gpu. Good catch.
| @@ -0,0 +1,3 @@ | |||
| class GiskardImportError(ImportError): | |||
| def __init__(self, missing_package: str) -> None: | |||
| self.msg = f"The '{missing_package}' Python package is not installed; please execute 'pip install {missing_package}' to obtain it." | |||
There was a problem hiding this comment.
Shouldn't we call super().init ?
There was a problem hiding this comment.
it is called right after, I try to check first for the missing dependency.
There was a problem hiding this comment.
pretty sure there are only 3 lines in this file, did I miss something ?
There was a problem hiding this comment.
sorry, I thought you were talking about the HeadPoseDataloader.
In fact I copied the above from https://github.com/Giskard-AI/giskard/blob/858c3c101382fb6f1933ed388984fc69cacd7195/giskard/core/errors.py#L22-L24
if the init just assigns msg than it doesn't really matter. let me check.
There was a problem hiding this comment.
here's the ImportError class's init:
class ImportError(Exception):
def __init__(self, *args: object, name: str | None = ..., path: str | None = ...) -> None:
...
No description provided.