Feature/gsk 2448 slicing dataloader #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
fix-batching
to
feature/gsk-2424-improve-the-hierarchy-structure-see-ffhq
January 4, 2024 10:55
Base automatically changed from
feature/gsk-2424-improve-the-hierarchy-structure-see-ffhq
to
main
January 4, 2024 13:34
rabah-khalek
approved these changes
Jan 4, 2024
Comment on lines
+8
to
+9
| SingleLandmarkData = Tuple[np.ndarray, np.ndarray, Optional[Dict[Any, Any]]] | ||
| BatchedLandmarkData = Tuple[Tuple[np.ndarray], np.ndarray, Tuple[Optional[Dict[Any, Any]]]] |
| batched_elements[1] = np.array(batched_elements[1]) | ||
|
|
||
| def _collate_fn(self, elements: List[SingleLandmarkData]) -> BatchedLandmarkData: | ||
| batched_elements = list(zip(*elements, strict=True)) |
Contributor
There was a problem hiding this comment.
nice touch with the strict
| # for key in meta_keys | ||
| # } | ||
|
|
||
| return batched_elements |
Contributor
There was a problem hiding this comment.
Shame that I missed that one in the previous PR. We're definitely missing a lot of helpful tests.
Comment on lines
+44
to
+60
| self._cached_functions = [ | ||
| lru_cache(maxsize=cache_size)(func) if should_cache else func | ||
| for should_cache, func in [ | ||
| (cache_img, self._wrapped_dataloader.get_image), | ||
| (cache_marks, self._wrapped_dataloader.get_marks), | ||
| (cache_meta, self._wrapped_dataloader.get_meta), | ||
| ] | ||
| ] | ||
|
|
||
| def get_image(self, idx: int) -> np.ndarray: | ||
| return self._cached_functions[0](idx) | ||
|
|
||
| def get_marks(self, idx: int) -> Optional[np.ndarray]: | ||
| return self._cached_functions[1](idx) | ||
|
|
||
| def get_meta(self, idx: int) -> Optional[Dict]: | ||
| return self._cached_functions[2](idx) |
Comment on lines
+76
to
+83
| def __init__(self, dataloader: DataIteratorBase, predicate: Callable[[SingleLandmarkData], bool]): | ||
| super().__init__(dataloader) | ||
| self._predicate_name = predicate.__name__ if hasattr(predicate, "__name__") else str(predicate) | ||
| self._reindex = [ | ||
| idx | ||
| for idx in self._wrapped_dataloader.idx_sampler | ||
| if predicate(self._wrapped_dataloader.get_single_element(idx)) | ||
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.