[GSK-2424] Improve a bit FFHQ structure #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hartorn
force-pushed
the
feature/gsk-2424-improve-the-hierarchy-structure-see-ffhq
branch
from
976a170 to
3b8a18d
Compare
Hartorn
force-pushed
the
feature/gsk-2424-improve-the-hierarchy-structure-see-ffhq
branch
from
3b8a18d to
23de9b5
Compare
rabah-khalek
reviewed
Jan 2, 2024
| self.marks_paths = None | ||
| # If landmarks folder is not none, we should load them | ||
| # Else, the get marks method should be overridden | ||
| if landmarks_dir_path is not None: |
Contributor
There was a problem hiding this comment.
landmarks_dir_path is a mandatory parameter since we're treating only the "supervised" case, this should never be None, actually we should raise an error if it is.
Member
Author
There was a problem hiding this comment.
I'm doing this to allow for extension as for ffhq (ie to provide another way to load the marks).
Not the cleanest, but this make is easier to extend the class
rabah-khalek
approved these changes
Jan 4, 2024
rabah-khalek
deleted the
feature/gsk-2424-improve-the-hierarchy-structure-see-ffhq
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.