Skip to content

Conversation

@pierlj
Copy link
Member

@pierlj pierlj commented Dec 29, 2023

Added multiples metrics:

  • NEs: normalised euclidean distance
  • NERFMark: per landmark and per image test whether the prediction is within a given radius around the ground truth
  • NERFImagesMean: mean of NERFMark in the image dimension, i.e. per landmark failure rate given the radius average on all images.
  • NERFImagesStd: same as above for std.
  • NERFMarksMean: mean of NERFMark in the mark dimension, i.e. per image failure rate given the radius average on all marks.
  • NERFMarksStd: same as above for std
  • NERFImages: proportion of images that have at least failed_mark_ratio landmarks that are not inside the radius around the ground truth.

Added unit tests for these metrics.

Changed the location and name of _calculate_d_outers --> compute_d_outers now in loreal_poc/marks/utils.py.
Also changed a bit the drawing method to display mark with their radius (check ex_8_NERF_metric.ipynb to see an example).

@linear
Copy link

linear bot commented Dec 29, 2023

GSK-2348 New test on landmarks-level

pre-aggregation of NME: Number of landmarks allowed to not respecting the threshold (radius around the ground-truth)

@pierlj pierlj requested a review from rabah-khalek December 29, 2023 17:31
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise LGTM

@pierlj pierlj requested a review from rabah-khalek January 10, 2024 11:34
@pierlj pierlj force-pushed the GSK-2348-add-landmarks-level-tests branch from b57636c to 100377f Compare January 10, 2024 11:39
@rabah-khalek rabah-khalek merged commit 011b29b into main Jan 10, 2024
@rabah-khalek rabah-khalek deleted the GSK-2348-add-landmarks-level-tests branch January 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants