Skip to content

Conversation

@tituslhy
Copy link
Contributor

@tituslhy tituslhy commented Jun 12, 2025

Description

Implement abstract methods aembed_query and aembed_documents for RagasEmbeddingsWrapper. These methods are required because the RagasEmbeddingsWrapper inherits from the BaseRagasEmbeddings class which has these abstract methods.

Related Issue

This PR is related to issue number 2177.

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • ��� New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)
@davidberenstein1957 davidberenstein1957 self-requested a review June 18, 2025 07:43
@davidberenstein1957 davidberenstein1957 added safe for build Lockfile Temporary label to update pdm.lock labels Jun 18, 2025
@henchaves henchaves added Lockfile Temporary label to update pdm.lock and removed Lockfile Temporary label to update pdm.lock labels Jun 23, 2025
@henchaves henchaves merged commit cb478d3 into Giskard-AI:main Jun 23, 2025
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants