Skip to content

[GSK-4133] Fix RAGReport save and load methods for when KB is not set #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2025
Merged

[GSK-4133] Fix RAGReport save and load methods for when KB is not set #2100

merged 3 commits into from
Feb 3, 2025

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Jan 30, 2025

Description

This PR fixes the save and load methods of RAGReport objects for when there is no Knowledge Base set.

Related Issue

GitHub: #2097
Linear: GSK-4133

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
@linear
Copy link

linear bot commented Jan 30, 2025

GSK-4133 giskard.rag.report.save fails if evaluate doesn't include KnowlegeBase #2097
@henchaves henchaves self-assigned this Jan 30, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 30, 2025 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
@kevinmessiaen kevinmessiaen merged commit 3b3136c into main Feb 3, 2025
19 checks passed
@kevinmessiaen kevinmessiaen deleted the feature/gsk-4133-giskardragreportsave-fails-if-evaluate-doesnt-include branch February 3, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@henchaves @kevinmessiaen