[GSK-4014] Set encoding as utf-8 for all open statements #2088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this branch for Quickstart script sections 1 through 3, and confirming it runs successfully now (on Windows running python via Jupyter Notebook script). |
henchaves
changed the title
|
kevinmessiaen
approved these changes
Dec 19, 2024
kevinmessiaen
deleted the
feature/gsk-4014-set-encoding-as-utf-8-for-all-open-statements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows, some giskard methods were failing because the default encoding type is different than utf-8. This PR explicitly set the default encoding as utf-8 for each I/O call.
Related Issue
Linear card: GSK-4014
GitHub issue: #2083
Type of Change