Skip to content

Add force_ascii=False when generating JSONL #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Add force_ascii=False when generating JSONL #2049

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d62137b
Add force_ascii=False when generating JSONL
PierreMesure Oct 22, 2024
686f66b
Add ensuire_ascii=False in json.dump
PierreMesure Oct 22, 2024
b264662
Add a test to export and reimport a Swedish testset
PierreMesure Oct 22, 2024
5f17bc0
Update giskard/rag/report.py
henchaves Oct 24, 2024
8a7a414
Update giskard/rag/report.py
henchaves Oct 24, 2024
d0cde0a
Format file
henchaves Oct 24, 2024
25b4e61
Format file
henchaves Oct 24, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update giskard/rag/report.py
  • Loading branch information
@henchaves
henchaves authored Oct 24, 2024
commit 8a7a414f6ed54052fe2dc4eb316ab6bec3b5b021
6 changes: 5 additions & 1 deletion giskard/rag/report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@ def save(self, folder_path: str):
json.dump(self._knowledge_base.get_savable_data(), f, ensure_ascii=False)

with open(path / "agent_answer.json", "w", encoding="utf-8") as f:
json.dump([{"message": output.message, "documents": output.documents} for output in self._model_outputs], f, ensure_ascii=False)
json.dump(
[{"message": output.message, "documents": output.documents} for output in self._model_outputs],
f,
ensure_ascii=False
)

if self._metrics_results is not None:
with open(path / "metrics_results.json", "w", encoding="utf-8") as f:
Expand Down
Loading