Skip to content

[GSK-3827] Fix load/save giskard Dataset #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2024
Merged

[GSK-3827] Fix load/save giskard Dataset #2039

merged 6 commits into from
Oct 11, 2024

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Oct 10, 2024

Description

This PR fixes a bug in which giskard Datasets were not being saved and loaded properly.

Related Issue

GSK-3827 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
@linear
Copy link

linear bot commented Oct 10, 2024

GSK-3827 Load scan test suite doesn't work
@henchaves henchaves self-assigned this Oct 10, 2024
kevinmessiaen
kevinmessiaen reviewed Oct 11, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud
@henchaves henchaves merged commit 6cdde2f into main Oct 11, 2024
18 checks passed
@henchaves henchaves deleted the feature/gsk-3827-load-scan-test-suite-doesnt-work branch October 11, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@henchaves @kevinmessiaen