Skip to content

Conversation

@kevinmessiaen
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)
@kevinmessiaen kevinmessiaen marked this pull request as ready for review September 18, 2024 09:31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the threshold defined on an ARM mac?
Our CI machines are mostly on Intel and it could import some extra libraries such as cudnn etc.
Could these be the root causes that we are exceeding the threshold?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I defined the threshold based on my machine (arm mac).

Seems like it only fail on Python 3.12 (linux). Might be due to a specific library that we import you're right, I need to get access to a x86 linux device to analyse the import time of each module and see what goes wrong.

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway

@kevinmessiaen kevinmessiaen merged commit cfc1347 into main Sep 18, 2024
@kevinmessiaen kevinmessiaen deleted the fix/tests-randomly-failing branch September 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants