Skip to content

Conversation

@kevinmessiaen
Copy link
Member

@kevinmessiaen kevinmessiaen commented Jul 1, 2024

Description

Fixed bug that prevented to create an empty df

Following code now works:

import pandas as pd
import giskard

giskard.Dataset(df=pd.DataFrame([], columns=["test"]))

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)
@kevinmessiaen kevinmessiaen requested a review from henchaves July 1, 2024 10:11
@sentry
Copy link

sentry bot commented Jul 1, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: giskard/core/dataset_validation.py

Function Unhandled Issue
_check_hashability IndexError: index 0 is out of bounds for axis 0 with size 0 main ...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

@henchaves
Copy link
Member

It doesn't work here :(

image
@kevinmessiaen
Copy link
Member Author

kevinmessiaen commented Jul 2, 2024

@henchaves I fixed the issue, I was using the wrong params

@kevinmessiaen kevinmessiaen requested a review from a team July 2, 2024 08:27
@kevinmessiaen kevinmessiaen enabled auto-merge July 3, 2024 03:25
@kevinmessiaen kevinmessiaen merged commit 1cfd7ae into main Jul 3, 2024
@kevinmessiaen kevinmessiaen deleted the bug/creating_empty_df branch July 3, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants