Skip to content

Prevent torch faulty version on MacOS #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

Prevent torch faulty version on MacOS #1855

merged 1 commit into from
Mar 19, 2024

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Mar 19, 2024

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been
    modified)
@Hartorn Hartorn requested a review from mattbit March 19, 2024 09:36
@Hartorn Hartorn self-assigned this Mar 19, 2024
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Mar 19, 2024
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Mar 19, 2024
@Hartorn Hartorn force-pushed the fix-torch-segfault branch from 4fb943c to e216634 Compare March 19, 2024 12:17
@Hartorn Hartorn marked this pull request as ready for review March 19, 2024 12:18
@Hartorn Hartorn requested a review from rabah-khalek March 19, 2024 12:18
@Hartorn Hartorn force-pushed the fix-torch-segfault branch from e216634 to 2eea09b Compare March 19, 2024 12:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud
rabah-khalek
rabah-khalek approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@rabah-khalek rabah-khalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working, let's just add torch to the llm group in pyproject.toml
@Hartorn Hartorn merged commit c3b8075 into main Mar 19, 2024
@Hartorn Hartorn deleted the fix-torch-segfault branch March 19, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Hartorn @rabah-khalek