Skip to content

Docs: replace space duplication instructions by docker template creation instructions #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 14, 2024
Merged

Docs: replace space duplication instructions by docker template creation instructions #1704

merged 8 commits into from
Jan 14, 2024

Conversation

@luca-martial
Copy link
Contributor

@luca-martial luca-martial commented Dec 28, 2023

Description

Replace space duplication instructions by docker template creation instructions.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix
@luca-martial luca-martial added the documentation Improvements or additions to documentation label Dec 28, 2023
Inokinoki
Inokinoki reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we mention how to manually upgrade Giskard version after creating the space?

The version is fixed in our Dockerfile for HFS now.
@luca-martial
Copy link
Contributor Author

luca-martial commented Jan 4, 2024

Should we mention how to manually upgrade Giskard version after creating the space?

Ah yes good point, do you mind adding those instructions? I'll double check after
@Inokinoki
Copy link
Member

Inokinoki commented Jan 4, 2024

Should we mention how to manually upgrade Giskard version after creating the space?

Ah yes good point, do you mind adding those instructions? I'll double check after

Sure, glad to work on it
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud
@luca-martial luca-martial merged commit 1bd7c8e into main Jan 14, 2024
@luca-martial luca-martial deleted the doc/hf-docker-template-addition branch January 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

4 participants

@luca-martial @Inokinoki @andreybavt