GSK-1943 - make jobs cancellable from the Hub #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreybavt
commented
Dec 21, 2023
giskard/commands/cli_worker.py
Outdated
| run_daemon(is_server, url, api_key, hf_token) | ||
| else: | ||
| if sys.platform == "win32": | ||
| if sys.platform == "win32" or sys.version_info < (3, 10): |
Contributor
Author
There was a problem hiding this comment.
uvloop didn't work on my my with python 3.9, but it's technically not related to the feature, so can remove for now
andreybavt
requested review from
Hartorn,
Inokinoki and
kevinmessiaen
and removed request for
Hartorn and
Inokinoki
andreybavt
commented
Dec 24, 2023
| run_daemon(is_server, url, api_key, hf_token) | ||
| else: | ||
| if sys.platform == "win32": | ||
| if settings.force_asyncio_event_loop or sys.platform == "win32": |
Contributor
Author
There was a problem hiding this comment.
I have issues when debugging worker from intellij when uvloop is used. I added the flag mostly for myself, but in case the same problems appear in prod there'll be a way to let people switch from one implementation to the other
Hartorn
requested changes
Jan 3, 2024
# Conflicts: # giskard/ml_worker/websocket/listener.py # tests/communications/test_websocket_actor.py
Hartorn
approved these changes
Jan 4, 2024
# Conflicts: # giskard/ml_worker/websocket/__init__.py # giskard/ml_worker/websocket/utils.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main PR - https://github.com/Giskard-AI/giskard-hub/pull/289