Skip to content

Add ipcc model and dataset creation for e2e tests #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Add ipcc model and dataset creation for e2e tests #1684

merged 1 commit into from
Dec 18, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Dec 18, 2023

Description

Needed for https://github.com/Giskard-AI/giskard-hub/pull/301

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
@Hartorn Hartorn requested review from henchaves and mattbit December 18, 2023 10:08
@Hartorn Hartorn self-assigned this Dec 18, 2023
@Hartorn Hartorn marked this pull request as ready for review December 18, 2023 10:08
@Hartorn Hartorn force-pushed the origin/fix-e2e branch 2 times, most recently from 105593b to 49d3dec Compare December 18, 2023 10:19
@kevinmessiaen kevinmessiaen self-requested a review December 18, 2023 10:33
kevinmessiaen
kevinmessiaen approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Hartorn Hartorn enabled auto-merge (rebase) December 18, 2023 11:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 18, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud
@Hartorn Hartorn merged commit 7580f02 into main Dec 18, 2023
@Hartorn Hartorn deleted the origin/fix-e2e branch December 18, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@Hartorn @henchaves @kevinmessiaen