Skip to content

Fix CI (breaking because of pdm and windows-2019) #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 14, 2023
Merged

Fix CI (breaking because of pdm and windows-2019) #1679

merged 4 commits into from
Dec 14, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Dec 14, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
@Hartorn Hartorn self-assigned this Dec 14, 2023
@Hartorn Hartorn changed the title Empty commit to get baseline for CI Dec 14, 2023
@Hartorn Hartorn marked this pull request as ready for review December 14, 2023 09:48
@Hartorn Hartorn requested review from a team, Inokinoki and andreybavt December 14, 2023 09:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud
andreybavt
andreybavt reviewed Dec 14, 2023
View reviewed changes
.github/workflows/build-python.yml
pydantic_v1: false
pandas_v1: false
langchain_minimal: false
# - python-version: "3.10" # Deactivating windows-2019, since it's trying to use python 3.7 to install PDM. Maybe try to reactivate later ?
Copy link
Contributor

@andreybavt andreybavt Dec 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's delete it as long as there's windows-2022 that remains and nobody asked for 2019 yet
@Hartorn Hartorn merged commit 2a6dfaf into main Dec 14, 2023
@Hartorn Hartorn deleted the fix-ci branch December 14, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Hartorn @andreybavt