Skip to content

Add huggingface report template #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2023
Merged

Add huggingface report template #1656

merged 4 commits into from
Dec 8, 2023

Conversation

@cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Dec 4, 2023 •
edited
Loading

Description

Add details and examples for markdown report.
Initiated a new template specifically for huggingface.

Before

Screenshot 2023-12-04 at 14 42 46

After

Screenshot 2023-12-06 at 15 00 54

demo: https://huggingface.co/spaces/ZeroCommand/test-giskard-bot/discussions/11

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
@linear
Copy link

linear bot commented Dec 4, 2023

GSK-2270 Wording on the scan report
cy-moi
cy-moi commented Dec 4, 2023
View reviewed changes
@cy-moi cy-moi marked this pull request as ready for review December 4, 2023 14:03
@cy-moi cy-moi requested a review from Inokinoki December 4, 2023 14:03
Inokinoki
Inokinoki reviewed Dec 5, 2023
View reviewed changes
@cy-moi cy-moi requested a review from Inokinoki December 6, 2023 13:58
@cy-moi cy-moi mentioned this pull request Dec 6, 2023
Merged
Inokinoki
Inokinoki approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can use this by passing huggingface as template name
@Inokinoki Inokinoki enabled auto-merge (squash) December 8, 2023 10:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information
@Inokinoki Inokinoki merged commit 1da6ba0 into main Dec 8, 2023
@Inokinoki Inokinoki deleted the GSK-2270-add-hf-scan-report-template branch December 8, 2023 11:15
@Inokinoki
Copy link
Member

Inokinoki commented Dec 10, 2023

Finished [GSK-2271] as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@cy-moi @Inokinoki