Skip to content

Cast to string in text slicer [GSK-2185] #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2023
Merged

Cast to string in text slicer [GSK-2185] #1637

merged 2 commits into from
Nov 24, 2023

Conversation

@mattbit
Copy link
Member

@mattbit mattbit commented Nov 24, 2023

Prevents detectors from breaking when a column declared as text contains non-textual values.
@linear
Copy link

linear bot commented Nov 24, 2023

GSK-2185 Detectors fail when string column contains "null" values

Reported by Nicolas Malt

  • Arrive quand j'ai des strings nulls dans mon dataset, le scan fini quand même mais sans résultat pour ces detectors

image.png
@mattbit mattbit added bug Something isn't working scan Created by Linear-GitHub Sync labels Nov 24, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication
@kevinmessiaen kevinmessiaen merged commit e780fed into main Nov 24, 2023
@kevinmessiaen kevinmessiaen deleted the task/scan-faild-null-vals branch November 24, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working scan Created by Linear-GitHub Sync

3 participants

@mattbit @kevinmessiaen