Skip to content

Conversation

@rabah-khalek
Copy link
Contributor

  • exposing description in giskard.Model in order to be able to do this:
    evaluator_config={
      "model_config":
       {"name": "Climate Change Question Answering",
        "description": "This model answers any question about climate change based on IPCC reports",
        "feature_names": ["query"],}
      }
    instead of
    evaluator_config={
      "model_config":
       {"name": "Climate Change Question Answering",
        "kwargs": {"description": "This model answers any question about climate change based on IPCC reports"},
        "feature_names": ["query"],}
      }
  • reformatting the metrics names logged into mlflow
@rabah-khalek
Copy link
Contributor Author

How it looks like
Screenshot 2023-10-31 at 17 19 35

@rabah-khalek rabah-khalek requested a review from mattbit October 31, 2023 16:20
@rabah-khalek rabah-khalek self-assigned this Oct 31, 2023
@rabah-khalek
Copy link
Contributor Author

restore the old metric display for the classical scan, and have another format for LLMs

@rabah-khalek
Copy link
Contributor Author

I restored the old nomenclature for the tests generated by the traditional scan.
the check on metric_name == "Metric" is not sustainable I know, but this is the easiest way out I could find right know.

Let's solve this properly in GSK-2041
Screenshot 2023-11-02 at 12 40 37

@rabah-khalek
Copy link
Contributor Author

the LLM case
Screenshot 2023-11-02 at 14 18 39

@rabah-khalek rabah-khalek merged commit 389c167 into main Nov 2, 2023
@rabah-khalek rabah-khalek deleted the GSK-2030 branch November 2, 2023 13:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants