Skip to content

Conversation

@Inokinoki
Copy link
Member

Description

Related Issue

[GSK-1383] Make dataset and model as suite input, when generating the test suite from scan
[GSK-1419] Add the possibility to set default run parameters to a test suite

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
@linear
Copy link

linear bot commented Oct 24, 2023

GSK-1383 Make dataset and model as suite input, when generating the test suite from scan

  • Tests generated by the scan Issue must not set the model and dataset parameters and instead use the global ones passed to the test suite at execution time
  • Add the scanned model and dataset in the ScanReport object
  • Suite object: add possibility to set some parameters at the suite instance level (GSK-1419).
    • either set_params or similar method or directly in the __init__, pass some kwargs and store at the instance level
    • take those params as default when using run (self._params.copy().update(runtime_args))
    • make sure that the instance level params are uploaded when calling Suite::upload

Note: even if the suite parameters will not be automatically set in the Hub UI, it’s ok. Just upload the Suite with its tests which are not bound to specific model or dataset and make sure that the model and dataset are uploaded separately.

Scan code snippet:

report = giskard.scan(model, dataset)

suite = report.generate_test_suite()
suite.upload(...). # this must upload suite, ++model, and ++dataset

Two problems we want to solve:

  1. the fact that we can’t change model and dataset easily when running the generated test suite
  2. we want to keep the automatic upload of the test suite with its artefacts model, dataset

GSK-1419 Add the possibility to set default `run` parameters to a test suite

jmjm those parameters would be used when calling runmethod of a suite and fix blocking issue for GSK-1383

@mattbit
Copy link
Member

mattbit commented Oct 25, 2023

@Inokinoki is this ready to review?

@Inokinoki Inokinoki requested a review from mattbit October 25, 2023 09:04
Copy link
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

@mattbit mattbit self-assigned this Oct 25, 2023
@Inokinoki Inokinoki requested a review from mattbit October 25, 2023 10:17
@sonarqubecloud
Copy link

@Inokinoki Inokinoki merged commit 63727f4 into main Oct 25, 2023
@Inokinoki Inokinoki deleted the feature/gsk-1419-gsk-1383-make-dataset-and-model-as-suite-input branch October 25, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants