Skip to content

Conversation

@Inokinoki
Copy link
Member

Description

Our latest image could disappear (or not on the first 10 items in Docker Hub repository), where the client will get stuck on parsing.
Use the version matching the local Giskard client in this case, and handle a few edge cases during upgrade.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
@linear
Copy link

linear bot commented Oct 11, 2023

GSK-1813 Giskard server upgrade runs for 20mns without returning any logs

Discovered during user test with Maximilien (unifai). Comments from weixuan :

Yes, I also encountered in the demo instance. It got stuck somewhere as we discussed during the meeting yesterday. As a workaround, I modified the version in the config file under $GISKARD_HOME.

@Hartorn Hartorn force-pushed the feature/gsk-1813-giskard-server-upgrade-runs-for-20mns-without-returning-any branch from b079187 to a4b5625 Compare October 11, 2023 08:04
@sonarqubecloud
Copy link

@Hartorn Hartorn merged commit 6ee3b17 into main Oct 11, 2023
@Hartorn Hartorn deleted the feature/gsk-1813-giskard-server-upgrade-runs-for-20mns-without-returning-any branch October 11, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants