LLM scan #1450
LLM scan #1450
Conversation
# Conflicts: # backend/src/main/resources/config/liquibase/master.xml
# Conflicts: # backend/src/main/resources/config/liquibase/master.xml # python-client/giskard/scanner/__init__.py # python-client/giskard/scanner/report.py # python-client/giskard/scanner/scanner.py # python-client/giskard/visualization/templates/_issues_table.html
# Conflicts: # python-client/docs/tutorials/data-types/text/index.md
kevinmessiaen
requested review from
Hartorn,
mattbit and
rabah-khalek
and removed request for
mattbit
Hartorn
left a comment
Hartorn
left a comment
There was a problem hiding this comment.
Not much to say on code structure :)
| return self | ||
|
|
||
| @remove_test.register | ||
| def _remove_test_by_name(self, test_name: str): |
There was a problem hiding this comment.
I guess mehod could be rename for clarity
| from pydantic import BaseModel, Field | ||
|
|
||
| from ..config import llm_config | ||
| from ...scanner.llm.utils import LLMImportError |
There was a problem hiding this comment.
It may be more readable to use absolute import giskard.xx.
# Conflicts: # giskard/models/base/model.py
|
SonarCloud Quality Gate failed.
|
|
Closing this and reopening a new one |
|
Detection part is in #1468 There are still commits in here that should be kept to align with the hub functionality. |
I'm looking to integrate them on the other branch |
Description
Added a new "business" detector that allow to scan generate functional issues for LLM tasks:
Type of Change